porting dynamic-sidecar to pyndatic2 #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 8, 2024 09:27
…upgrade-dynamic-sidecar
…upgrade-dynamic-sidecar
…ade-dynamic-sidecar
GitHK
changed the title
added 2 commits
October 10, 2024 10:48
…ade-dynamic-sidecar
…upgrade-dynamic-sidecar
| "application/json": { | ||
| "schema": { | ||
| "$ref": "#/components/schemas/ActivityInfo" | ||
| "anyOf": [ |
There was a problem hiding this comment.
Did you notice that now (it seems OpenAPI 3.1) the nullable fields have this new schema with anyOf and the new type "null"?
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/settings.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/settings.py
Outdated
Show resolved
Hide resolved
|
We should bring this one direct to |
|
closing in favour of ITISFoundation#6534 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Currently I'm stuck, waiting for service-library service to be properly fixed.
Related issue/s
How to test
Dev-ops checklist